[CI][KVConnector][Metrics] Update multi KV connector edge case according to prefill stats changes#39808
Merged
markmc merged 2 commits intovllm-project:mainfrom Apr 14, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests for the KV connector to reflect changes in metric reporting. Specifically, it modifies the expected values for local_compute and local_cache_hit across several test cases, ensuring that local_compute is now expected to be 0 and local_cache_hit matches the full cached count. I have no feedback to provide as there were no review comments to evaluate.
markmc
approved these changes
Apr 14, 2026
markmc
changed the title
github-actions
Bot
added
the
ready
Signed-off-by: Zhanqiu Hu <zhu@redhat.com>
auto-merge was automatically disabled
April 14, 2026 16:13
Head branch was pushed to by a user without write access
ZhanqiuHu
force-pushed
the
fix/multi-connector-metrics-assertions
branch
from
2da40eb to
83db6c9
Compare
zxd1997066
pushed a commit
to zxd1997066/vllm
that referenced
this pull request
Apr 15, 2026
…ing to prefill stats changes (vllm-project#39808) Signed-off-by: Zhanqiu Hu <zhu@redhat.com> Signed-off-by: zengxian <xiangdong.zeng@intel.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
…ing to prefill stats changes (vllm-project#39808) Signed-off-by: Zhanqiu Hu <zhu@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…ing to prefill stats changes (vllm-project#39808) Signed-off-by: Zhanqiu Hu <zhu@redhat.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrefillStatswith strict non-overlapping token source accounting (local_compute + local_cache_hit + external_kv_transfer = num_prompt_tokens).local_compute, sincePrefillStats.set()is called before the-1adjustment in_update_waiting_for_remote_kv().test_multi_connector_edge_cases.py:local_compute:1→0local_cache_hit:cached - 1→cachedTest
run_multi_connector_edge_case_test.shEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.